Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-191 File names must have valid characters #947

Closed
parthea opened this issue Mar 16, 2022 · 0 comments · Fixed by #948
Closed

AIP-191 File names must have valid characters #947

parthea opened this issue Mar 16, 2022 · 0 comments · Fixed by #948
Assignees
@parthea
Labels
priority: p2 type: bug

Comments

@parthea
Copy link
Contributor

parthea commented Mar 16, 2022 •
edited
Loading

AIP-191 states File names must use snake_case but api-linter does not check for invalid characters.

Valid Character Ranges include:
a-z
A-Z
0-9
_

Anything else could be considered invalid.

As an example, a proto filename should be test_service.proto not test.service.proto

Question: Should A-Z be considered valid?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(AIP-191): valid characters in filename googleapis/api-linter
1 participant
@parthea