Resize handler now resizes #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbuso
reviewed
Mar 7, 2018
src/ad-ui.js
Outdated
| this.adsManagerDimensions.height = height; | ||
| if (this.controller.sdkImpl.adsManager) { | ||
| this.controller.sdkImpl.adsManagerDimensions.width = width; | ||
| this.controller.sdkImpl.adsManagerDimensions.height = height; | ||
| /* global google */ | ||
| /* eslint no-undef: 'error' */ | ||
| this.adsManager.resize(width, height, google.ima.ViewMode.NORMAL); |
There was a problem hiding this comment.
This call will still fail since AdUi doesn't own adsManager, sdkImpl does. I think to fix this we actually want to move this whole method to SdkImpl, and in controller.js instead of calling adUi.onPlayerResize() we want to call sdkImpl.onPlayerResize().
There was a problem hiding this comment.
Sorry, that's a blatant oversight on line 446 that should read:
this.controller.sdkImpl.adsManager.resize(width, height, google.ima.ViewMode.NORMAL);However, point taken. Will refactor into sdkImpl.onPlayerResize()
added 2 commits
March 7, 2018 17:47
Fixes:
```
1) Basic Tests chrome-local
Displays skip ad button chrome-local:
WebDriverError: unknown error: call function result missing 'value'
2) Basic Tests chrome-local
Nonlinear chrome-local:
WebDriverError: unknown error: call function result missing 'value'
```
|
@shawnbuso is this what you had in mind? |
|
Yea that's perfect, thanks! |
|
Nice - my first foray into this project post the |
|
Glad to hear! I also like the workflow a lot more post-v1 :) |
bustbr
pushed a commit
to bustbr/videojs-ima
that referenced
this pull request
Apr 24, 2018
* Resize handler now resizes - fix for googleads#554 * Fix failing tests due to outdated chromedriver. Fixes: ``` 1) Basic Tests chrome-local Displays skip ad button chrome-local: WebDriverError: unknown error: call function result missing 'value' 2) Basic Tests chrome-local Nonlinear chrome-local: WebDriverError: unknown error: call function result missing 'value' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #554