Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in resize event handler #554

Closed
steevee opened this issue Mar 7, 2018 · 0 comments
Closed

Bug in resize event handler #554

steevee opened this issue Mar 7, 2018 · 0 comments
Assignees
@steevee
Labels
bug P1

Comments

@steevee
Copy link
Contributor

steevee commented Mar 7, 2018

It appears that resizing should be automatically catered for in the IMA plugin, but think I've spotted a bug in the v1.x release preventing it.

AdUi.onPlayerResize() will never resize because AdUi.adManagers does not exist.

I'm not sure if the adsManagers should be a property of the AdUi, but since it's accessible via the AdUi.controller.sdkImpl.adsManager, it should be a simple enough fix.
steevee pushed a commit to steevee/videojs-ima that referenced this issue Mar 7, 2018
Resize handler now resizes - fix for googleads#554
bb6a74c
@steevee steevee mentioned this issue Mar 7, 2018
Merged
steevee pushed a commit to steevee/videojs-ima that referenced this issue Mar 7, 2018
Resize handler now resizes - fix for googleads#554
aa2d901
shawnbuso pushed a commit that referenced this issue Mar 7, 2018
@steevee @shawnbuso
fix: Resize handler now resizes (#555)
a10e82f 
* Resize handler now resizes - fix for #554

* Fix failing tests due to outdated chromedriver.
Fixes:
```
  1) Basic Tests chrome-local
       Displays skip ad button chrome-local:
     WebDriverError: unknown error: call function result missing 'value'

  2) Basic Tests chrome-local
       Nonlinear chrome-local:
     WebDriverError: unknown error: call function result missing 'value'
```
bustbr pushed a commit to bustbr/videojs-ima that referenced this issue Apr 24, 2018
@steevee @bustbr
fix: Resize handler now resizes (googleads#555)
4e48a7f 
* Resize handler now resizes - fix for googleads#554

* Fix failing tests due to outdated chromedriver.
Fixes:
```
  1) Basic Tests chrome-local
       Displays skip ad button chrome-local:
     WebDriverError: unknown error: call function result missing 'value'

  2) Basic Tests chrome-local
       Nonlinear chrome-local:
     WebDriverError: unknown error: call function result missing 'value'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steevee steevee

Labels
bug P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawnbuso @steevee