Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Lighthouse 6.0.0-beta.0 #198

Merged
merged 11 commits into from
May 13, 2020
Merged

Upgrade to Lighthouse 6.0.0-beta.0 #198

merged 11 commits into from
May 13, 2020

Conversation

jburger424
Copy link
Contributor

@jburger424 jburger424 commented May 12, 2020 •
edited
Loading

  • Include 10th percentile scores to support Lighthouse v6.0 computeLogNormalScore changes (thanks @brendankenny!).
  • Update runWarnings usage (thanks @paulirish!).
  • Include numericUnits.
  • Other minor fixes.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA has not been signed label May 12, 2020
@jburger424
Copy link
Contributor Author

@brendankenny can you consent to googlebot?

@brendankenny
Copy link
Collaborator

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels May 12, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no CLA has not been signed and removed cla: yes CLA has been signed labels May 12, 2020
@paulirish
Copy link
Collaborator

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels May 12, 2020
@paulirish paulirish mentioned this pull request May 13, 2020
Closed
@jburger424 jburger424 requested a review from warrengm May 13, 2020 16:50
@jburger424 jburger424 changed the title Add p10 score-curve control points Upgrade to Lighthouse 6.0.0-beta.0 May 13, 2020
@jburger424 jburger424 requested a review from brendankenny May 13, 2020 16:54
brendankenny
brendankenny approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulirish not sure if you want to do a 6.0.0-rc or beta.1 or whatever with what you cut last night (or today?) just to be really sure this works with latest :)

@jburger424 jburger424 requested a review from jonkeller May 13, 2020 19:01
@jburger424
Copy link
Contributor Author

Force merging this to release beta package for LH, will resolve travis issues tomorrow.

@jburger424 jburger424 merged commit 91f685b into master May 13, 2020
@jburger424 jburger424 deleted the p10 branch May 13, 2020 22:08
@paulirish paulirish mentioned this pull request May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@warrengm warrengm Awaiting requested review from warrengm

@jonkeller jonkeller Awaiting requested review from jonkeller

Assignees
No one assigned
Labels
cla: yes CLA has been signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jburger424 @googlebot @brendankenny @paulirish