Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mintegral Mediation Adapter #1078

Merged
merged 4 commits into from
May 9, 2024
Merged

Mintegral Mediation Adapter #1078

merged 4 commits into from
May 9, 2024

Conversation

LTPhantom
Copy link
Collaborator

Description

Adds a new Flutter plugin that enabled Mintegral Mediation Adapter to use with the google_mobile_ads flutter plugin.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@LTPhantom LTPhantom marked this pull request as ready for review May 8, 2024 18:53
Copy link
Collaborator

@jjliu15 jjliu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, just some minor questions/comments.

// See the License for the specific language governing permissions and
// limitations under the License.

/// This empty class is needed to allow correct compatibility analysis with host platforms.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What fails without this class?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside pub.dev score, Platform Support cannot identify which platforms the plugin is compatible with.
Screenshot 2024-05-08 at 5 04 57 PM

@LTPhantom LTPhantom merged commit f3af1f2 into main May 9, 2024
27 checks passed
@LTPhantom LTPhantom deleted the mintegralAdapter branch May 10, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants