Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code health improvement for release #1070

Merged
merged 14 commits into from
May 7, 2024
Merged

General code health improvement for release #1070

merged 14 commits into from
May 7, 2024

Conversation

LTPhantom
Copy link
Collaborator

@LTPhantom LTPhantom commented May 3, 2024

Description

General code health improvement for release

Issues Resolved

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@malandr2
Copy link
Collaborator

malandr2 commented May 3, 2024

Can we resolve #1036 in this PR if possible? Related to code health 🙂

@LTPhantom LTPhantom marked this pull request as ready for review May 6, 2024 21:16
@LTPhantom
Copy link
Collaborator Author

Can we resolve #1036 in this PR if possible? Related to code health 🙂

Sure, I can verify if the changes already do.

@LTPhantom
Copy link
Collaborator Author

Can we resolve #1036 in this PR if possible? Related to code health 🙂

This resolves it now. Added to the PR description

@LTPhantom LTPhantom requested a review from malandr2 May 6, 2024 23:02
@LTPhantom LTPhantom merged commit f051424 into main May 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants