Add transmute_container! macro #1736
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
container-transmute
branch
from
f555762
to
713dbed
Compare
jswrenn
reviewed
Sep 24, 2024
src/lib.rs
Outdated
| @@ -303,6 +303,7 @@ | |||
| __ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS, | |||
| feature(layout_for_ptr, strict_provenance, coverage_attribute) | |||
| )] | |||
| #![cfg_attr(feature = "unstable-transmute-vec", feature(vec_into_raw_parts))] | |||
There was a problem hiding this comment.
We should attempt to move the trait impl for Vec into the macro, so that feature(vec_into_raw_parts) is something our customers write instead of us. This makes it harder for customers to accidentally and unkowingly depend on a nightly feature (e.g., because another dependency enabled this cargo feature).
There was a problem hiding this comment.
Any ideas for how to do that given that the macro delegates to a trait impl and doesn't have access to the name of the container type being used?
There was a problem hiding this comment.
Ugly but bear with me: Move the trait and impl to inside the macro.
There was a problem hiding this comment.
Discussed offline. Going to just remove Vec support for now.
joshlf
force-pushed
the
container-transmute
branch
4 times, most recently
from
27dcf55
to
d54acba
Compare
joshlf
force-pushed
the
container-transmute
branch
from
d54acba
to
c51c96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation of #1735