Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.33.0 is incorrectly marked as supporting Python2.7 #1154

Closed
Spitfire1900 opened this issue Sep 24, 2023 · 10 comments · Fixed by #1157
Closed

Version 0.33.0 is incorrectly marked as supporting Python2.7 #1154

Spitfire1900 opened this issue Sep 24, 2023 · 10 comments · Fixed by #1157

Comments

@Spitfire1900
Copy link
Contributor

Not sure what the fix is here, but I realized today that version 0.33.0 does not support python2.7 but was inadvertently uploaded to PyPi as such. The last version that supported python2.7 was 0.32.0 and a fresh installation attempt of yapf when using python2.7 should not resolve to any newer version.

kyle@mainstay:~/Repos/yapf$ pip2.7 install yapf
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Defaulting to user installation because normal site-packages is not writeable
Collecting yapf
  Using cached yapf-0.33.0-py2.py3-none-any.whl (200 kB)
ERROR: Could not find a version that satisfies the requirement tomli>=2.0.1 (from yapf) (from versions: none)
ERROR: No matching distribution found for tomli>=2.0.1 (from yapf)
@Spitfire1900 Spitfire1900 changed the title Cersion 0.33.0 is incorrectly marked as supporting Python2.7 Version 0.33.0 is incorrectly marked as supporting Python2.7 Sep 24, 2023
@Spitfire1900
Copy link
Contributor Author

Spitfire1900 commented Sep 25, 2023

Maybe yank 0.33.0 and replace with a 0.33.0-post1? 0.40.0 should be consider for yanking also if we go that far.

@Spitfire1900
Copy link
Contributor Author

@bwendling , thoughts here?

@bwendling
Copy link
Member

I'm not sure what's the best course of action. If we want to replace it, then we should go with 0.33.1 or something, since we'll have to adjust the supported versions information in the source. I'm half-tempted to just remove it period and tell everyone that 0.32.0 is the last Python 2.7 version... I'm not sure how badly that's going to affect people.

@Spitfire1900
Copy link
Contributor Author

Spitfire1900 commented Sep 27, 2023

Replacing it with 0.33.1 as a py3 only release will still cause 0.33.0 to be incorrectly resolved as the "final" py2 release.

My understanding is that "yanked" is just metadata, so that yapf>=0.32.0 will resolve to 0.32.0 on py2.

I would suspect that pinned 0.33.0 in peoples' requirements.txt and lock files would still install 0.33.0 even if it is yanked.

Need someone whose actually worked with yanking and/or testing on Test PyPi as part of this.

https://peps.python.org/pep-0592/ Pep on yanking

@Spitfire1900
Copy link
Contributor Author

To clarify, my suggestion does not involve deleting the release from PYPI but to mark the release as yanked.

@Spitfire1900
Copy link
Contributor Author

@Spitfire1900
Copy link
Contributor Author

I would mark 0.33.0 and 0.40.0 as yanked, testing in Test PyPi first.

@bwendling
Copy link
Member

SGTM. I went ahead and marked them as "yanked".

@Spitfire1900
Copy link
Contributor Author

@bwendling I've confirmed that 0.32.0 is now the latest version that resolves.

kyle@mainstay:~/Repos/yapf$ python2.7 -m pip install yapf
Collecting yapf
  Using cached yapf-0.32.0-py2.py3-none-any.whl (190 kB)
Installing collected packages: yapf
Successfully installed yapf-0.32.0
kyle@mainstay:~/Repos/yapf$ 

bwendling pushed a commit that referenced this issue Sep 29, 2023
Both 0.33.0 and 0.40.0 were yanked due to packaging issues.

Caused by #1107 and #1154
@bwendling
Copy link
Member

Thank you for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants