Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shout errors from CallAsync callback to avoid silent failures #182

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Shout errors from CallAsync callback to avoid silent failures #182

merged 1 commit into from
Mar 26, 2017

Conversation

dbarnett
Copy link
Contributor

@dbarnett dbarnett commented Mar 21, 2017 •
edited
Loading

Fixes part of #124.

@dbarnett dbarnett requested a review from malcolmr March 25, 2017 16:49
malcolmr
malcolmr approved these changes Mar 26, 2017
View reviewed changes
Copy link
Member

@malcolmr malcolmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(sorry, took a while for me to work out what was going on here.)

@dbarnett
Copy link
Contributor Author

Yeah, no worries. Looks like GitHub's diff isn't great here and I kinda bombarded you with code reviews besides.

@dbarnett dbarnett merged commit 408eb9c into master Mar 26, 2017
@dbarnett dbarnett deleted the callasync_shout branch March 26, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmr malcolmr malcolmr approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbarnett @malcolmr @googlebot