Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env_dict param from Syscall.CallAsync callbacks #180

Open
dbarnett opened this issue Mar 20, 2017 · 1 comment
Open

Remove env_dict param from Syscall.CallAsync callbacks #180

dbarnett opened this issue Mar 20, 2017 · 1 comment
Milestone

Comments

@dbarnett
Copy link
Contributor

Syscall.CallAsync expects a callback with signature callback({env_dict}, {result_dict}), where env_dict contains cursor and vim state info. In practice, it's not easy to remember the argument order, and it's easy enough and more explicit/flexible for the caller to just capture the env info they need and bind it to the callback with maktaba#function#Create.

We should migrate Syscall.CallAsync to expect a signature callback({result_dict}) instead and just document how callers can capture and pass info along.

@dbarnett
Copy link
Contributor Author

Reopening to track cleanup. We should change it to shout an error after a couple weeks, and then remove it entirely about a month after that.

@dbarnett dbarnett modified the milestones: 1.0, 1.13.0, 2.0 Mar 25, 2017
dbarnett added a commit that referenced this issue Mar 27, 2017
Changes since 1.12.0:
  * Syscall.CallAsync improvements (#180, #124, #183).
  * Fix maktaba#log# error on reload (#187).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant