-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: test against coveragepy 4.x #31
base: master
Are you sure you want to change the base?
Conversation
I couldn't tell, was there a reason we needed a particular version range? If so, could you capture that reason in comments somewhere? |
@dbarnett |
Travis runs are failing saying "No module named coverage". Is there something missing still? |
Did you end up figuring out the failures any further? We do have issues like #39 where the problem turned out to be specific to newer versions of coveragepy. |
I do not remember. |
Rebased (to fix conflict). |
.travis.yml
Outdated
- if [ -z "$COVERAGEPY" ]; then | ||
sudo apt-get install python-coverage3; | ||
else | ||
wget https://bootstrap.pypa.io/get-pip.py && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to execute this after downloading it? Otherwise I think you're running the system version of pip below.
Here's a working version from one of our other .travis.yml files: https://github.com/google/vim-codefmt/blob/c84463dbed1408abb4003b2105211488d47423d9/.travis.yml#L18
That fetches for version 3.5 explicitly or it blows up on Travis not running python >=3.6, and we sudo to install the packages "system-wide" on the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the wget - it seems using the system Python is fine here.
Have not looked at the other reference - I am not sure if putting more time into the Travis config is worth it, given that it likely will run out of OSS credits in the long run anyway, and needs to be replaced by e.g. GitHub Actions then.
Oof, I hadn't realized that was a risk. I'll probably still pick this up and try to get it working at some point regardless. It will still be useful to figure out a working set of commands for testing against different coveragepy versions, whatever CI system we may end up using. Anyway, thanks for getting the ball rolling! |
No description provided.