Add cursor support #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2015 22:54
- add suport for version checking - if version high enough, add java support - if version high enough, add cursor control
- invalidate cache on executable change - bump required maktaba version - add tests
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it. |
|
CLAs look good, thanks! |
|
Generally looks reasonable, though:
|
| let l:supports_cursor = s:ClangFormatHasAtLeastVersion([3, 4]) | ||
| if l:supports_cursor | ||
| " line2byte counts bytes from 1, and col counts from 1, so -2 | ||
| let l:cursor_pos = line2byte(line(".")) + col(".") - 2 |
|
Not sure what you mean by "interfere with #43". I think this implements it. Custom formatters will take precedence, since we install the built-ins as "defaults" that come last in the lookup order. |
|
fixed tests. PTAL |
|
pulled out the java stuff so we can handle it separately |
| @@ -163,7 +191,7 @@ function! codefmt#GetClangFormatFormatter() abort | |||
| function l:formatter.AppliesToBuffer() abort | |||
| return &filetype is# 'c' || &filetype is# 'cpp' || | |||
| \ &filetype is# 'proto' || &filetype is# 'javascript' | |||
| endfunction | |||
| endfunction: | |||
There was a problem hiding this comment.
You've got a stowaway colon here.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cursor support and java support with conditional version checking for both. I have not regenerated the documentation, because my experiments with vimdoc failed.