-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perl formatting support using Perltidy #227
base: master
Are you sure you want to change the base?
Conversation
Sorry, I think since the tests weren't passing this fell through the cracks. I think if you can rebase your changes on top of the latest upstream and address my comment there to fix the tests, this looks ready to merge otherwise. |
must be installed on your system. (But not for testing; vroom intercepts | ||
system calls.) | ||
:FormatCode perltidy | ||
! perltidy .* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to fake the command output like this:
vim-codefmt/vroom/clangformat.vroom
Line 46 in c6730fb
$ { "Cursor": 0 } |
Otherwise the tests can't run without perltidy installed (and may get brittle, failing depending on the version of perltidy installed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, and I'm not sure if I'm doing right because I don't really understand the syntax of .vroom
.
Signed-off-by: liuyehcf <[email protected]>
Signed-off-by: liuyehcf <[email protected]>
I can help update the tests if a current maintainer can review. @malcolmr @fowles @snu5mumr1k |
Here ya go, patch dbarnett@de65871 and you should be good to go. |
Solves #210