Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadRandom and reimplement NewRandomFromReader using it #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joewreschnig
Copy link
Contributor

@joewreschnig joewreschnig commented Jul 31, 2021

Combined with e.g. bufio.Reader this provides fast zero-allocation
UUID generation if you do not consider heap memory particularly
sensitive, without a global state or lock.

I guess this is my proposal re. the discussion about #80/#86/#88. It's faster than both of them and the single new function opens up other optimization possibilities they don't, e.g. if you already have some pathological [1000]UUID you need to fill.

I didn't remove the original pool implementation because in the end that's a question of the module's specific commitment to its API compatibility rather than a technical one.

Combined with e.g. `bufio.Reader` this provides fast zero-allocation
UUID generation if you do not consider heap memory particularly
sensitive, without a global state or lock.
@rittneje
Copy link

As mentioned in #88 (comment) this does not address the ever-growing number of constructors in this package. It also means someone intending to use crypto/rand.Rand has to explicitly pass it in order to gain any performance benefit from this.

@rittneje
Copy link

I didn't remove the original pool implementation because in the end that's a question of the module's specific commitment to its API compatibility rather than a technical one.

There is also the fact that it could sneakily be enabled by some transitive dependency. One of many reasons I chose to throw it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants