Pin Datastore to work around upstream bug #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum library versions are not set correctly for some of the upstream cloud libraries so we'll need to pin them for now. See the following for more details on the bug: googleapis/google-cloud-python#6390 This can be removed once grr-client-api updates its pinned version of protobuf. The grr-client-api library gets pulled in from dfTimewolf, which also has Turbinia as a dependency. The bug referenced above gets tickled when both of these libraries are installed at the same time (because the Datastore package doesn't correctly limit the minimum versions of its dependencies, an incompatible version gets installed).
|
@tomchop & @pstirparo: FYI |
Onager
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum library versions are not set correctly for some of the upstream cloud libraries so we'll need to pin them for now. See the following for more details on the bug:
googleapis/google-cloud-python#6390
This can be removed once grr-client-api updates its pinned version of protobuf. The grr-client-api library gets pulled in from dfTimewolf, which also has Turbinia as a dependency. The bug referenced above gets tickled when both of these libraries are installed at the same time (because the Datastore package doesn't correctly limit the minimum versions of its dependencies, an incompatible version gets installed).