Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go from 1.19 to 1.20 #3080

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Bump go from 1.19 to 1.20 #3080

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5cad9
Bump go from 1.19 to 1.20
mhutchinson Aug 31, 2023
93dc292
Fix setup-go checking out go1.2 instead of 1.20
mhutchinson Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: 1.19
go-version: 1.20

- uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0
with:
Expand All @@ -35,7 +35,7 @@ jobs:

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: '1.19'
go-version: '1.20'
check-latest: true
cache: true

Expand All @@ -49,7 +49,7 @@ jobs:

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
with:
go-version: '1.19'
go-version: '1.20'
check-latest: true
cache: true

Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## HEAD

* Recommended go version for development: 1.20
* This is the version used by the cloudbuild presubmits. Using a
different version can lead to presubmits failing due to unexpected
diffs.


## v.1.5.2

* Recommended go version for development: 1.19
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ The current state of feature implementation is recorded in the

To build and test Trillian you need:

- Go 1.19 or later (go 1.19 matches cloudbuild, and is preferred for developers
- Go 1.20 or later (go 1.20 matches cloudbuild, and is preferred for developers
that will be submitting PRs to this project).

To run many of the tests (and production deployment) you need:
Expand Down
2 changes: 1 addition & 1 deletion examples/deployment/docker/db_client/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-buster
FROM golang:1.20-buster

RUN apt-get update && \
apt-get install -y mariadb-client
Expand Down
2 changes: 1 addition & 1 deletion examples/deployment/docker/log_server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-buster as build
FROM golang:1.20-buster as build

WORKDIR /trillian

Expand Down
2 changes: 1 addition & 1 deletion examples/deployment/docker/log_signer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-buster as build
FROM golang:1.20-buster as build

WORKDIR /trillian

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/trillian

go 1.19
go 1.20

require (
bitbucket.org/creachadair/shell v0.0.7
Expand Down
2 changes: 1 addition & 1 deletion integration/cloudbuild/testbase/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This Dockerfile builds a base image for Trillan integration tests.
FROM golang:1.19-buster
FROM golang:1.20-buster

WORKDIR /testbase

Expand Down