Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully exit the program when the lease expired #2656

Closed
wants to merge 3 commits into from

Conversation

px3303
Copy link
Contributor

@px3303 px3303 commented Jan 15, 2022

This PR can let trillian proactively Listen "LeaseKeepAliveResponse" channel returned by KeepAlive in ETCD client. When automatic renewal interruption is detected, Exit the program by canceling the context.

Fixes #2654,#2249

Checklist

px3303 and others added 3 commits January 12, 2022 18:39
Listen "LeaseKeepAliveResponse" channel returned by keepalive in ETCD client. When automatic renewal interruption is detected, the caller will be informed through Context, and then the caller can cancel the global context to exit the progrd.
@px3303 px3303 requested a review from a team as a code owner January 15, 2022 11:30
@px3303 px3303 requested a review from pphaneuf January 15, 2022 11:30
@px3303 px3303 closed this Jan 15, 2022
@px3303
Copy link
Contributor Author

px3303 commented Jan 19, 2022

Moved to #2655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeepAlive in etcd client cannot ensure the permanent validity of lease
2 participants