Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts may not be executable, invoke with bash #1673

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Scripts may not be executable, invoke with bash #1673

merged 1 commit into from
Jun 12, 2019

Conversation

gdbelvin
Copy link
Contributor

When referenced from a go-module enabled project, the scripts referenced by functions.sh may not be executable.

Solution: invoke them directly with bash.

@gdbelvin gdbelvin requested a review from RJPercival June 11, 2019 15:57
@gdbelvin gdbelvin mentioned this pull request Jun 11, 2019
Merged
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #1673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1673   +/-   ##
=======================================
  Coverage   68.54%   68.54%           
=======================================
  Files         104      104           
  Lines        8914     8914           
=======================================
  Hits         6110     6110           
  Misses       2201     2201           
  Partials      603      603

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97074a1...7093cbc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #1673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1673   +/-   ##
=======================================
  Coverage   68.54%   68.54%           
=======================================
  Files         104      104           
  Lines        8914     8914           
=======================================
  Hits         6110     6110           
  Misses       2201     2201           
  Partials      603      603

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97074a1...7093cbc. Read the comment docs.

@gdbelvin gdbelvin requested a review from taknira June 12, 2019 11:29
@gdbelvin
Copy link
Contributor Author

Related issue: golang/go#31481

@RJPercival RJPercival removed the request for review from taknira June 12, 2019 13:16
@gdbelvin gdbelvin merged commit 05461f4 into google:master Jun 12, 2019
@gdbelvin gdbelvin deleted the functions branch June 12, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RJPercival RJPercival RJPercival approved these changes

Assignees

@gdbelvin gdbelvin

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdbelvin @RJPercival @googlebot