Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Fix #467: pass the Google Maps API key to the schedule viewer. #486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #467: pass the Google Maps API key to the schedule viewer. #486

wants to merge 2 commits into from

Conversation

andrew-hardin
Copy link

This is a straightforward fix that resolves issue #467 by allowing the GMaps API key to be configured by the Python server.

A related note: the default API key registered to [email protected] seems to still be valid 👍

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@andrew-hardin andrew-hardin changed the title Fix #Pass the Google Maps API key to the schedule viewer. Fix #467: pass the Google Maps API key to the schedule viewer. Jul 13, 2019
@andrew-hardin
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@amenk
Copy link

amenk commented Nov 16, 2019

@andrew-hardin The CI fails, do you know why?

@andrew-hardin
Copy link
Author

@amenk: not sure why it failed, but I merged the branch with a recent copy of master and the build passed.

@answerquest
Copy link

Hi, is this good to go?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants