Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Date chip to support milliseconds #2867

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Update Date chip to support milliseconds #2867

merged 6 commits into from
Aug 28, 2023

Conversation

sydp
Copy link
Collaborator

@sydp sydp commented Aug 14, 2023 •
edited by jkppr
Loading

Fixes #2869

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes
(if such).

@sydp sydp changed the title [DRAFT] Update Date chip to support milliseconds Update Date chip to support milliseconds Aug 15, 2023
@sydp sydp marked this pull request as ready for review August 15, 2023 07:47
@sydp sydp requested a review from jaegeral August 15, 2023 07:48
@jkppr jkppr requested review from jkppr and removed request for jaegeral August 28, 2023 06:22
jkppr
jkppr approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr merged commit 5bd795c into google:master Aug 28, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkppr jkppr jkppr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Client] Update search module to support millisecond dates
3 participants
@sydp @jkppr @jaegeral