Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework comments #2845

Merged
merged 11 commits into from
Jul 17, 2023
Merged

Rework comments #2845

merged 11 commits into from
Jul 17, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Jul 16, 2023

This PR will hide the comments column in the event details per default and display a new "add comments" icon on the top instead. When clicked, the user can add a comment like it used to be.

If the event already has a comment, it will be displayed by default.

closes #2677

@jkppr jkppr added the Frontend label Jul 16, 2023
@jkppr jkppr self-assigned this Jul 16, 2023
@jkppr jkppr marked this pull request as ready for review July 17, 2023 11:51
@jkppr jkppr requested a review from berggren July 17, 2023 11:52
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr merged commit 990cc51 into google:master Jul 17, 2023
20 checks passed
@jkppr jkppr deleted the 2677_rework_comments branch July 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Comments block a lot of space
2 participants