tools/syz-declextract: don't analyze host files #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've got this error when trying to run the tool: arch/x86/tools/relocs_64.c: In file included from arch/x86/tools/relocs_64.c:2: In file included from arch/x86/tools/relocs.h:5: /usr/include/stdio.h:33:10: fatal error: 'stddef.h' file not found The arch/x86/tools/relocs_64.c is part of some host tool that was compiled with gcc. And probably my clang installation is somehow broken and can't compile normal user-space C programs. Skip files that were not compiled with clang. We don't need to analyze them (host tools), and it also solves my clang problem.
|
@pimyn-girgis please review |
|
LGTM. |
pimyn-girgis
approved these changes
Oct 15, 2024
|
@a-nogikh need approval from somebody with write access to merge |
a-nogikh
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got this error when trying to run the tool:
arch/x86/tools/relocs_64.c: In file included from arch/x86/tools/relocs_64.c:2:
In file included from arch/x86/tools/relocs.h:5:
/usr/include/stdio.h:33:10: fatal error: 'stddef.h' file not found
The arch/x86/tools/relocs_64.c is part of some host tool
that was compiled with gcc. And probably my clang installation
is somehow broken and can't compile normal user-space C programs.
Skip files that were not compiled with clang.
We don't need to analyze them (host tools),
and it also solves my clang problem.