dyvukov refactor api #5394
Merged
dyvukov refactor api #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dvyukov
commented
Oct 11, 2024
dvyukov
commented
- dashboard/api: add package
- tools/syz-reprolist: use official API structs
- dashboard/app: rename test file
- dashboard/api: add Client type
- tools/syz-reprolist: switch to dashboard/api.Client
|
I wanted to do some analysis on fixed bugs, need this in reusable form. |
Move JSON API structs to a separate package. These definitions are also needed by tools that consume the API.
Use the official API structs to avoid duplication, prevent future bugs, and improve consistency (same field names).
dvyukov
force-pushed
the
dyvukov-refactor-api
branch
from
a48e2e9
to
c2487e2
Compare
tarasmadan
reviewed
Oct 14, 2024
tarasmadan
reviewed
Oct 14, 2024
tarasmadan
reviewed
Oct 14, 2024
tarasmadan
previously approved these changes
Oct 14, 2024
Rename test file to match the tested file.
dvyukov
force-pushed
the
dyvukov-refactor-api
branch
from
c2487e2
to
9bb2650
Compare
dvyukov
force-pushed
the
dyvukov-refactor-api
branch
from
9bb2650
to
8c452f1
Compare
dvyukov
force-pushed
the
dyvukov-refactor-api
branch
from
8c452f1
to
fe85eb9
Compare
tarasmadan
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.