executor/common_lunux.h/usbip_server_init: Close fd if can't find usb port #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvyukov
previously approved these changes
Jun 26, 2024
auto-merge was automatically disabled
June 26, 2024 16:26
Head branch was pushed to by a user without write access
AKSUMRUS
force-pushed
the
patch-7
branch
3 times, most recently
from
529a67e
to
ccb92a0
Compare
|
The CI checks fail: |
If usb port for usbip server can't be found, fd of the server and client should be closed. If they don't closed, the number of open files will increase and may overflow the number of available open files. Signed-off-by: Pavel Nikulshin <[email protected]>
a-nogikh
reviewed
Jul 15, 2024
| @@ -2067,6 +2070,8 @@ static long syz_usbip_server_init(volatile long a0) | |||
| sprintf(buffer, "%d %d %s %d", port_num, client_fd, "0", speed); | |||
|
|
|||
| write_file("/sys/devices/platform/vhci_hcd.0/attach", buffer); | |||
|
|
|||
| close(client_fd); | |||
There was a problem hiding this comment.
It would be nice to have some comment re. why we can close the client_fd here. Won't it break something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If usb port for usbip server can't be found, fd of the server and client should be closed.
If they don't closed, the number of open files will increase and may overflow the number of available open files.