Update C++ styleguide #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Guidance for return values (prefer return by value, return by reference, then return by pointer in that order) - Mandate curly braces around the body of a control statement, providing one exception for historical reasons (`if` with no `else`, and `if` + body fits completely in a single line or the `if` fits in one line and the body fits in another separate line).
|
@tituswinters Please take a look when you have a chance. Thanks! |
wp-seth
reviewed
Nov 11, 2020
| @@ -1719,6 +1719,9 @@ <h3 id="Inputs_and_Outputs">Inputs and Outputs</h3> | |||
| improve readability, and often provide the same or better | |||
| performance.</p> | |||
|
|
|||
| <p>Prefer to return by value or, failing that, return by reference. | |||
| Avoid returning a pointer unless it can be null.</p> | |||
There was a problem hiding this comment.
Suggested change
| Avoid returning a pointer unless it can be null.</p> | |
| Avoid returning a pointer unless you take care of the case if it is null.</p> |
otherwise it could be misunderstood.
tituswinters
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference, then return by pointer in that order)
providing one exception for historical reasons (
ifwith noelse,and
if+ body fits completely in a single line or theiffits inone line and the body fits in another separate line).