Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ styleguide #577

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

zetafunction
Copy link
Contributor

  • add section for inclusive language.
  • move include-what-you-use to a new section.
  • clarify usage of absl::optional for by-value vs by-reference params.
  • document usage of `` as a code-indexing hint
  • note that enclosing identifiers in `` can help code indexers.

@google-cla
Copy link

google-cla bot commented Sep 24, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 24, 2020
- add section for inclusive language.
- move include-what-you-use to a new section.
- clarify usage of absl::optional for by-value vs by-reference params.
- document usage of `` as a code-indexing hint
- note that enclosing identifiers in `` can help code indexers.
@zetafunction zetafunction force-pushed the how-does-this-work-again branch from 31bdc94 to 3919c34 Compare September 25, 2020 07:30
@google-cla
Copy link

google-cla bot commented Sep 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@zetafunction
Copy link
Contributor Author

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Sep 25, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@zetafunction
Copy link
Contributor Author

@tituswinters Please take a look when you have a chance. Thanks!

In the future, I'm going to try to do these merges regularly every quarter.

@tituswinters tituswinters merged commit 96f6a64 into google:gh-pages Sep 25, 2020
@zetafunction zetafunction deleted the how-does-this-work-again branch January 27, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants