This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Maintainers,
please accept this PR that fixes #229
This issues causes stenographer to panic, if a query is executed under these circumstances:
after
and/orbefore
critieriaUnder the above circumstances, the query uses the method
BlockFile.AllPackets
as a shortcut. This is harcoded to assume that stenotype has written 1MB blocks.This fix will work, provided that the classes in stenotype extending
Packets
, ensure that the fieldblock->hdr.bh1.blk_len
is populated with the actual size of the block.This is already the case with
PacketsV3
but I do not know whether it is also the case withTestimonyPackets
.