Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included additional metrics to be exposed. Only 6/7 metrics are being exposed if I am using the promethues as a backend and the pushgateway as an exporter. #493

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ppothepa24
Copy link

I have made changes to the files in base.py and report.py to ensure that additional metrics namely (error_budget_target, error_budget_measurement, error_budget_burn_rate, error_budget_remaining_minutes, error_budget_minutes etc) be exposed. But i am not sure if these changes are actually being compiled and executed as the changes in the source code arent reflecting in the output.

Copy link

google-cla bot commented Jul 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lvaylet
Copy link
Collaborator

lvaylet commented Jul 8, 2024

Hi @ppothepa24, I will take a look later this week. I have a lot on my plate right now, and find myself unable to spend as much time as I'd like on the SLO Generator.

@lvaylet
Copy link
Collaborator

lvaylet commented Jul 12, 2024

I replied in #490 (reply in thread).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants