-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): allow to setup the Datadog host URL #359
Conversation
Hi @sdenef-adeo, I understand the rationale behind this request. This being said, I do not understand how the Datadog client will be able to use the host defined in these environment variables. Unlike |
329431a
to
20fd1ee
Compare
Sorry, I made a typo, then I updated the PR. It's Also part of docs/provides/datadog.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Just a tiny change and we can merge.
20fd1ee
to
24115cb
Compare
DATADOG_HOST renamed to DATADOG_API_HOST |
Thanks @sdenef-adeo. Let me take care of the new vulnerabilities reported by |
The new vulnerability reported by |
For local tests purposes, we may want to update the Datadog host URL used for Datadog API requests.
Example: testing rate limiting
Running a local NginX server acting as a Datadog API mock. We can set a dedicated rate-limit config without burning our Datadog instance (called "organization" by Datadog) quota.
Reminder: https://docs.datadoghq.com/api/latest/rate-limits/