Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Add Splunk as a backend provider #335

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

mveroone
Copy link
Contributor

@mveroone mveroone commented Feb 28, 2023

Pretty straightforward, even though it's somehow a new exercice for me to go that deep into the code.

The goal of that PR is to implement a new backend provider : Splunk.
Since their APIs are the same, it should work both with Splunk CLoud or Splunk Enterprise (on premises)
I've tested it against the later, but should be able to test with both if needs be.

All new features are documented in the right directories and tests & mocks were implemented.

@google-cla
Copy link

google-cla bot commented Feb 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mveroone mveroone force-pushed the Feat/splunk_backend_new branch 3 times, most recently from cd2e3dd to 00f3339 Compare February 28, 2023 11:09
@bkamin29
Copy link

bkamin29 commented Apr 4, 2023

@lvaylet possible to schedule a meet about this issue ?
with my colleague @mveroone :)
We have some questions for you about this contribution and how to implement the count events part.

@lvaylet lvaylet self-assigned this May 10, 2023
@lvaylet lvaylet added feature New feature or request backend p/splunk labels May 10, 2023
Copy link
Collaborator

@lvaylet lvaylet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this Maxime! I really appreciate both the quality and comprehensiveness of the PR, and only detected a few minor changes/nitpicks.

Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
docs/providers/splunk.md Show resolved Hide resolved
docs/providers/splunk.md Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
slo_generator/backends/cloud_monitoring_mql.py Outdated Show resolved Hide resolved
tests/unit/fixtures/config.yaml Outdated Show resolved Hide resolved
tests/unit/test_compute.py Outdated Show resolved Hide resolved
@mveroone
Copy link
Contributor Author

mveroone commented May 30, 2023

FYI : commit is blocked by this for now :
#340

EDIT : I forced the commit with --no-verify, but I'll have to rebase to make it build

@mveroone mveroone force-pushed the Feat/splunk_backend_new branch from 68d506a to 044eead Compare May 30, 2023 12:37
@bkamin29
Copy link

Hello,
Same issue than @mveroone, cf #340 (comment)

@mveroone mveroone force-pushed the Feat/splunk_backend_new branch from 044eead to b5a8189 Compare June 13, 2023 08:33
@mveroone mveroone requested a review from lvaylet June 16, 2023 09:02
@mveroone
Copy link
Contributor Author

@lvaylet All your review points have been treated. Let me know if you have further remarks.
Thank you for your time.

@lvaylet
Copy link
Collaborator

lvaylet commented Jun 21, 2023

@mveroone Sounds good to me now. Thanks for your hard work and patience!

@lvaylet lvaylet merged commit 5171318 into google:master Jun 21, 2023
lvaylet pushed a commit that referenced this pull request Oct 20, 2023
* Backend: Add Splunk as a backend provider

Signed-off-by: Maxime Véroone <[email protected]>

* WIP reveiw

---------

Signed-off-by: Maxime Véroone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature New feature or request p/splunk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants