Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When i execute the slo-generator as api mode with a batch request with some files sample, by example this one : https://github.com/google/slo-generator/blob/master/samples/cloud_monitoring/slo_gae_app_latency.yaml
Because the yaml file separator is ";" in the batch process request method, you can see that here : https://github.com/google/slo-generator/blob/master/slo_generator/api/main.py#L205
And than the slo_gae_app_latency.yaml file has comments containing one ";", the file will be split to two parts to be compute
And we get the error (ERROR - SLO configuration is empty) in the output :
It is more standard and safer to use the yaml document markers as separator : https://yaml.org/spec/1.2.2/#document-markers
Currently, we can't send multiple yaml documents in one file with a standard way.
Thanks in advance for feedbacks.
Rgs,