feat: add configurable offset field to account for metrics ingestion delays
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update CI builds * Update Dockerfile, improve CloudBuild deployment * Add CI test configs
* Update .gitignore * Update Makefile * Remove buildpack builds and replace with Dockerfile-based builds
* feat!: Support slo-generator config v2 format (core changes) * Add step property * Fix kind filtering * Fix Istio cluster naming for Service Monitoring API + modularize logging format based on debug flag * Fix linting
* feat!: Upgrade slo-geneartor CLI to Click library * Change --version implementation to use pkg_resources instead of importlib which is different in Python 3.6 and above
* fix: Migrate sample configurations to v2
* Add --project-id to Cloud Run deployment * Add GCR release * Fix API Cloud Scheduler * Update release yaml * Update github workflow
* Update migrator to fail softly when invalid YAMLs are found * Add support for multiple error budget policies * Fix migrator * Fix lint * Fix dependency issue * Remove libgdal from Dockerfile
* Add CloudRun documentation * Update CloudRun doc * Update CloudBuild / CloudFunctions docs * Update docs, fix migrator output
* Fix linting after upgrading to pylint2.11 * Fix encoding in open call
Custom exporters are failing to load due to `capitalize`. This PR propagates the `get_backend()` logic to `get_exporters()`.
* add type hints * add more type hints * fix lint * cleanup * integrate mypy test to tests workflow * fix types test workflow * disable more pylint options * add new line to mypy.ini * disable warnings locally * change Pylint annotation position * update .pylintrc * fix misc errors * feat: add pytype linting (#249) * add pytype linting and fix all reported errors * revert metaclass fix to make tests pass * refactor Makefile * fix mypy errors * more specific types in prometheus.py * remove Optional type on arguments with default * update test workflow * fix lint * fix unsubscriptable-object errors * refactor variables declarations and some typings * add new line on .gitignore file * remove clean from mypy make cmd * keep line before cmd * bring back Optional type * bring back Optional type on utils.py * reverse last commit * add Optional type to args in utils.py * wrong arg type * fix annotation-type-mismatch in compute.py * fix attribute-error on main.py * fix line too long * fix indentation * fix return types * add Optional type * fix already defined variables * fix None has no attribute * fix line too long * update Makefile mypy script * reverse last changes * reverse cloud_monitoring_mql init refactoring * ignore lint duplicate code warnings * skip pytype attribute-error error to fix later * ignore attr-defined type errors * ignore union-attr type errors * ignore fixme pylint warning * add missing types dependencies Co-authored-by: Laurent Vaylet <[email protected]>
* configure setuptools using setup.cfg (PEP 517, PEP 518) * fix TOML syntax thah prevents CI from running * make FIXME messages more explicit * black 22.1.0 depends on click>=8.0.0 * add/configure black and isort * configure pylint in pyproject.toml * remove unused pylint config file * add/configure pre-commit * trim trailing whitespaces * fix linting/formatting globally * install pre-commit hooks in dev mode only * add/configure bandit and safety * add black, isort, bandit and safety to lint target and CI * update versions of GitHub Actions * add `make format` target (with isort then black) * update version of release-please GitHub Action * update contributing doc with new dev workflow and tools + fix/reformat Markdown * add sample output of pre-commit hook * detail how pre-commit hooks work * fix mypy warnings/errors * reformat Markdown * fix discrepancy on Python version and license name * add pytest and pytype temp folders to .gitgnore * configure mypy using pyproject.toml
Co-authored-by: Laurent Vaylet <[email protected]>
* add details on development workflow * fix markdown style violations
* add documentation for Cloud Monitoring MQL backend * fix markdown style violations
…toring` v2 (with breaking changes) (#280)
* add `cloud_monitoring_mql` backend section to sample config * update docs with missing backends
…toring exporter to prevent Quota Exceeded errors (#286)
… return the same results as MQF requests (#290)
* add bug report template * add feature request template * prevent users from creating blank issues (i.e. force them to use a template) * fix config file extension
* fix no_implicit_optional errors (cf. PEP 484) * fix package name
lvaylet
changed the title
offset field to handle metrics ingestion delaysoffset field to make up for metrics ingestion delays
|
Marking as "draft" as I want to add unit tests and update the documentation. |
lvaylet
changed the title
offset field to make up for metrics ingestion delaysoffset field to make up for metrics ingestion delays
lvaylet
changed the title
offset field to make up for metrics ingestion delaysoffset field to account for metrics ingestion delays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111.