Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: Prometheus Remote Write API #175

Closed
wants to merge 3 commits into from

Conversation

eraac
Copy link
Contributor

@eraac eraac commented Oct 13, 2021

closes #122

It's the first time I wrote Python code, there are probably a lot to say/review.

  • I've made a separate exporter but maybe it's better to add to the current prometheus exporter?
  • proto file is directly in slo_generator/exporters/ but maybe there a better path for it?
  • I'm not sure where I can add documentation about protobuf compilation

Concerning the .proto, I've copy the one from prometheus repository, and removing unnecessary element

Thanks!

eraac added 3 commits October 13, 2021 14:59
Signed-off-by: Kevin Labesse <[email protected]>
Signed-off-by: Kevin Labesse <[email protected]>
@oktocat
Copy link

oktocat commented Oct 13, 2021

loool we're doing the same thing #177
how do you want to go about it?

@eraac
Copy link
Contributor Author

eraac commented Oct 13, 2021

loool we're doing the same thing #177 how do you want to go about it?

What are the odds? But I think there are no discussion about which one is better 😅

@oktocat
Copy link

oktocat commented Oct 13, 2021

loool we're doing the same thing #177 how do you want to go about it?

What are the odds? But I think there are no discussion about which one is better sweat_smile

so, what do we do now? :)
I'll need a day or two to write all the tests and docs. Want to help? :trollface:

@eraac
Copy link
Contributor Author

eraac commented Oct 13, 2021

I close this one and merging our efforts into #177

@eraac eraac closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New exporter] Prometheus Remote Write
2 participants