Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2070 tag manager web stories #3813

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Feature/2070 tag manager web stories #3813

merged 2 commits into from
Aug 12, 2021

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Aug 9, 2021 •
edited
Loading

Summary

Addresses issue #2070

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Aug 9, 2021
eugene-manuilov
eugene-manuilov approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugene-manuilov eugene-manuilov merged commit faabe70 into develop Aug 12, 2021
@eugene-manuilov eugene-manuilov deleted the feature/2070-tag-manager-web-stories branch August 12, 2021 18:01
@swissspidy swissspidy mentioned this pull request Aug 23, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvinb @eugene-manuilov