-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/3012 analytics account summaries #3081
Enhancement/3012 analytics account summaries #3081
Conversation
…nalytics-account-summaries.
…nalytics-account-summaries.
…nalytics-account-summaries.
@eugene-manuilov Please keep in mind to connect PRs to their respective issues in the future (via ZenHub UI) :) |
@felixarntz it doesn't work anymore. It stopped working last week :( |
Hmm weird, it does for me. You don't see the UI at all or how is it not working? |
@felixarntz this is what I see when I try to connect this PR with the issue: |
Please, ignore the wrong issue number on my screenshot. It behaves the same when I try to connect a PR with a correct issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; one tiny documentation tweak but it's just a single word so I'll make it then approve 🙂
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great—so much simpler!
Can you add a QA brief to the issue? After that we can merge it 👍🏻
@tofumatt QAB is added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is a lot less complicated which is great 👍🏻
I tested this locally and it worked for me. Nice!
Summary
Addresses issue #3012
Relevant technical choices
Checklist