Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #2172
This PR is a follow-up to #2173 (merged) which didn't completely address the issue.
In #1865 we moved VRT to run on GitHub Actions. As part of this work, it was necessary to customize the Docker command that is used to run the tests, due to TTY complications on the Actions platform.
As a result, Backstop was upgraded to the latest version (5.x), however the necessary
dockerCommandTemplate
config argument has been available since v3.9.6After digging into this a bit more on the Backstop issues, I found a few issues of users having similar problems with newer versions of Backstop.
See garris/BackstopJS#1156 (I also saw this locally)
Screenshot
Anecdotally, stability of Backstop JS seems to have become problematic starting around v4.5, hence this PR rolls it back to the latest version which seems to be more stable for most people).
Relevant technical choices
Checklist