Locales with 100% translation still show some untranslated strings #1163
Comments
|
Happy to lend a hand here if needed 👍 |
|
FYI this is actively being worked on in WordPress/gutenberg#20555 Using that PR, those issues with the text domain could be fixed automatically instead of manually. |
|
Oh, and with that PR we can also automatically tackle #820. |
|
That's great news @swissspidy! I assume we would have to be using the latest 4.x version of the ESLint plugin to take advantage of this, once merged? I touched on this recently in #520 (comment) |
|
Most conveniently, yes. But if you want to tackle this specific issue already today you could also check out those Gutenberg PRs locally, build everything, and use This way you don't have to wait for the upgrade to happen, and don't have to fix anything else in the code base. |
|
IB ✅ |
|
Tested Flipped site language to Espanol Checked SK and I'm not seeing Spanish |
Click for Site Health Info` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 ` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 ` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 ` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 `` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 `` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 `` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 `` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 ` wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 wp-coreversion: 5.3.2 wp-paths-sizeswordpress_path: /srv/users/user5532cec1/apps/user5532cec1/public wp-active-themename: Twenty Twenty (twentytwenty) wp-themes-inactive (3)Twenty Nineteen: version: 1.4, author: the WordPress team wp-plugins-active (4)Companion Plugin: version: 1.11, author: Osk wp-plugins-inactive (2)Akismet Anti-Spam: version: 4.1.3, author: Automattic wp-mediaimage_editor: WP_Image_Editor_GD wp-serverserver_architecture: Linux 4.4.0-174-generic x86_64 wp-databaseextension: mysqli wp-constantsWP_HOME: undefined wp-filesystemwordpress: writable jetpacksite_id: false A healthy connection ensures Jetpack essential services are provided to your WordPress site, such as Stats and Site Security.</p> <span class="dashicons fail"><span class="screen-reader-text">Error</span></span> Your site is not connected to Jetpack. We recommend reconnecting Jetpack.</strong></p>","group":["default"],"type":"direct"}] google-site-kitversion: 1.4.0 |
|
@cole10up It depends on what you do first. If Site Kit is already installed and then you switch the site language, you'll need to go to Dashboard > Updates (Escritorio > Actualizaciones) to install the translations.
If you install Site Kit after the site language is changed, you don't need to do this as the plugin will be installed with the translations already (it might be a bit trickier to do if you aren't familiar with the language though 😉 ) |
|
Thanks for the clarity @aaemnnosttv Tested Uninstalled SK, installed spanish and flipped site language to spanish: Installing SK, the activation screen shows anonymous tracking copy in English: Dashboard activation screen: Dashboard post activation: Adsense setup: Analytics setup: Page speed insights: Tag Manager: Optimize: Connect more services: Analytics module: Disconnecting service: Settings Notice anonymous tracking copy isn't translated: |
|
Confirmed with @aaemnnosttv and @tofumatt that the untranslated anonymous tracking is expected as this code changed. Passed QA ✅ |
Bug Description
Using a locale with 100% translation, such as Spanish still results in some untranslated strings in the plugin. See https://translate.wordpress.org/projects/wp-plugins/google-site-kit/
Steps to reproduce
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
google-site-kittext domaindefaultPropsImplementation Brief
There are two problems:
google-site-kittext domainWould be great if we could add an ESLint rule for this to enforce with static analysis
site-kit-wp/assets/js/components/setup/setup-proxy.js
Lines 111 to 112 in a5a2060
defaultPropsThis doesn't work likely due to translation happening before locale is set. See:
assets/js/components/analytics-inactive-cta.jsassets/js/components/dashboard-splash/dashboard-splash-intro.jsassets/js/components/dashboard-splash/dashboard-splash-outro.jsassets/js/modules/adsense/settings/adsense-settings.jsThere could be other instances, so search well!
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: