Merge pull request #1082 from google/fix/345-dialog-accessibility

Update Dialog for accessibility
google · Feb 21, 2020 · a5a2060 · a5a2060
2 parents b4c10cd + 3aa4f35
commit a5a2060
Showing 1 changed file with 20 additions and 13 deletions.
diff --git a/assets/js/components/dialog.js b/assets/js/components/dialog.js
@@ -28,6 +28,7 @@ import FocusTrap from 'focus-trap-react';
 /**
  * WordPress dependencies
  */
+import { withInstanceId } from '@wordpress/compose';
 import { Component, createRef } from '@wordpress/element';
 import { __ } from '@wordpress/i18n';
 
@@ -61,16 +62,20 @@ class Dialog extends Component {
 			subtitle,
 			confirmButton,
 			dependentModules,
+			instanceId,
 		} = this.props;
 
+		const labelledByID = `googlesitekit-dialog-label-${ instanceId }`;
+		const describedByID = `googlesitekit-dialog-description-${ instanceId }`;
+
 		return (
 			<div
 				ref={ this.dialogRef }
 				className={ `mdc-dialog ${ dialogActive ? 'mdc-dialog--open' : '' }` }
 				role="alertdialog"
 				aria-modal="true"
-				aria-labelledby="remove-module-dialog"
-				aria-describedby="remove-module-dialog-description"
+				aria-labelledby={ title ? labelledByID : undefined }
+				aria-describedby={ ( provides && provides.length ) ? describedByID : undefined }
 				aria-hidden={ dialogActive ? 'false' : 'true' }
 				tabIndex="-1"
 			>
@@ -80,7 +85,7 @@ class Dialog extends Component {
 						<div className="mdc-dialog__container">
 							<div className="mdc-dialog__surface">
 								{ title &&
-									<h2 id="remove-module-dialog" className="mdc-dialog__title">
+									<h2 id={ labelledByID } className="mdc-dialog__title">
 										{ title }
 									</h2>
 								}
@@ -89,15 +94,17 @@ class Dialog extends Component {
 										{ subtitle }
 									</p>
 								}
-								<section id="remove-module-dialog-description" className="mdc-dialog__content">
-									<ul className="mdc-list mdc-list--underlined mdc-list--non-interactive">
-										{ provides && provides.map( ( attribute ) => (
-											<li className="mdc-list-item" key={ attribute }>
-												<span className="mdc-list-item__text">{ attribute }</span>
-											</li>
-										) ) }
-									</ul>
-								</section>
+								{ ( provides && provides.length ) &&
+									<section id={ describedByID } className="mdc-dialog__content">
+										<ul className="mdc-list mdc-list--underlined mdc-list--non-interactive">
+											{ provides.map( ( attribute ) => (
+												<li className="mdc-list-item" key={ attribute }>
+													<span className="mdc-list-item__text">{ attribute }</span>
+												</li>
+											) ) }
+										</ul>
+									</section>
+								}
 								{ dependentModules &&
 									<p className="mdc-dialog__dependecies">
 										<strong>{ __( 'Note: ', 'google-site-kit' ) }</strong>{ dependentModules }
@@ -140,4 +147,4 @@ Dialog.defaultProps = {
 	confirmButton: null,
 };
 
-export default Dialog;
+export default withInstanceId( Dialog );