Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto minimization #909

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Proto minimization #909

merged 2 commits into from
Oct 21, 2022

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Oct 21, 2022

Create new ProcessInfoLight and FileInfoLight message variants to reduce on-disk and on-wire size while minimizing the amount of actionable data sacrificed.

pmarkowsky
pmarkowsky approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The proto still isn't being used, so it's ok to rename it. In the future we'll need to be more careful.

Also since we got rid of the UUID, we might want to look into ULIDS next time if we bring back a unique identifier.

@mlw mlw merged commit 899ca89 into google:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

@russellhancox russellhancox russellhancox approved these changes

@tburgin tburgin Awaiting requested review from tburgin

@kallsyms kallsyms Awaiting requested review from kallsyms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlw @russellhancox @pmarkowsky