Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto serializer #897

Merged
merged 25 commits into from
Oct 13, 2022
Merged

Proto serializer #897

merged 25 commits into from
Oct 13, 2022

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Oct 4, 2022

  • Add enhanced protobuf schema
  • Add protobuf serializer
  • Reorganize common serializer code into a serializer utilities file
  • Remove "rules_proto_grpc" from the workspace, replace with "com_google_protobuf"

mlw added 21 commits October 4, 2022 16:23
@mlw
Initial proto serializer with close event
b6c4e9a
@mlw
Define move ctors for enriched types, delete copy ctors
b13364c
@mlw
More event proto serialization. Commonized proto test code.
5fc3b24
@mlw
Started work serializing exec event. Added serializer utilities.
b63d3fd
@mlw
More progress serializing exec event
d9795bd
@mlw
Add mroe test data. Test restructure to permit fine grained mocking.
fa78d8c
@mlw
Env/FD ES types now wrapped in EndpointSecurityAPI. Added calls to pr…
fecd424 
…oto serializer.
@mlw
Add fd type names to proto
eacf5f9
@mlw
Version compat. Script and Working Dir encoding.
df48cfe
@mlw
Add process start time
2010f73
@mlw
Serialize Link event
785d675
@mlw
Add null check, mainly to fix tests
c28407a
@mlw
Handle versioned expectations
76b0344
@mlw
Each test now build msg in callbacks to set better expectations
76cd24d
@mlw
Serialize rename event and tests
eccd24c
@mlw
Serialize unlink event and tests
dc7ce10
@mlw
Serialize allowlist and bundle events. Add utilities tests.
ef4feea
@mlw
Formatting
06d2fb5
@mlw
Disk event proto serialization and tests
5e07303
@mlw
Fix test only issues
b6d03df
@mlw
Rename santa_new.proto to santa.proto
da54541
@pmarkowsky pmarkowsky self-requested a review October 8, 2022 01:39
This was referenced Oct 11, 2022
Closed
Merged
@pmarkowsky pmarkowsky added the santad Work related to the Santa Daemon label Oct 11, 2022
pmarkowsky
pmarkowsky suggested changes Oct 11, 2022
View reviewed changes
Source/common/TestUtils.mm Show resolved Hide resolved
Source/common/santa.proto Outdated Show resolved Hide resolved
Source/common/santa.proto Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
Source/santad/Logs/EndpointSecurity/Serializers/Protobuf.mm Outdated Show resolved Hide resolved
Source/santad/Logs/EndpointSecurity/Serializers/Protobuf.mm Outdated Show resolved Hide resolved
Source/common/santa.proto Outdated Show resolved Hide resolved
pmarkowsky
pmarkowsky approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit 1683e09 into google:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

@kallsyms kallsyms Awaiting requested review from kallsyms

@russellhancox russellhancox Awaiting requested review from russellhancox

@tburgin tburgin Awaiting requested review from tburgin

Assignees
No one assigned
Labels
santad Work related to the Santa Daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlw @pmarkowsky