-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up endTimestamp to be Monarch compliant #879
Fix up endTimestamp to be Monarch compliant #879
Conversation
Source/santametricservice/Formats/SNTMetricMonarchJSONFormatTest.m
Outdated
Show resolved
Hide resolved
How I'm reading this - it appears like this will make the |
@mlw Short answer is yes. Monarch requires the time series to be reported constantly so as long as we have the value we have to record a new If we want |
This PR fixes an issue with our Monarch JSON that causes some metrics to be wonky.
Specifically our
endTimestamp
field needs to be the time of the export not thelast_updated
time.