Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

santactl/metrics: Allow filtering metrics #763

Merged
merged 4 commits into from
Mar 22, 2022
Merged

santactl/metrics: Allow filtering metrics #763

merged 4 commits into from
Mar 22, 2022

Conversation

russellhancox
Copy link
Contributor

And don't print metric type number if the name is known.

@pmarkowsky pmarkowsky added the metrics Code / work related to Santa observability / monitoring label Mar 22, 2022
@russellhancox
Copy link
Contributor Author

As discussed, updated to allow passing multiple filters.

pmarkowsky
pmarkowsky approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Source/common/SNTMetricSetTest.m Show resolved Hide resolved
@russellhancox russellhancox enabled auto-merge (squash) March 22, 2022 18:09
@russellhancox russellhancox merged commit 676c026 into google:main Mar 22, 2022
@russellhancox russellhancox deleted the metric-command branch March 22, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
metrics Code / work related to Santa observability / monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russellhancox @pmarkowsky