-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
santa-driver: add back the root and non-root caches #302
Conversation
@@ -102,6 +105,17 @@ void SantaDecisionManager::ConnectClient(pid_t pid) { | |||
|
|||
client_pid_ = pid; | |||
|
|||
// Determine root fsid | |||
vfs_context_t ctx = vfs_context_create(NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use nullptr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/** | ||
Clears the cache(s). If non_root_only is true, only the non-root cache | ||
is cleared. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent -1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
@@ -102,6 +105,17 @@ void SantaDecisionManager::ConnectClient(pid_t pid) { | |||
|
|||
client_pid_ = pid; | |||
|
|||
// Determine root fsid | |||
vfs_context_t ctx = vfs_context_create(NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/** | ||
Clears the cache(s). If non_root_only is true, only the non-root cache | ||
is cleared. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* santa-driver: add back the root and non-root caches * cachehistogram: clarify buckets and entries * review changes
This pull is mainly a line by line cherrypick revert of 15fa53d.