Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

santa-driver: add back the root and non-root caches #302

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

tburgin
Copy link
Contributor

@tburgin tburgin commented Sep 26, 2018

  • santa-driver now supports 64 bit file system ids. Identifying root and non-root file system ids on executing binaries seems to now work consistently.
  • Clarify buckets and entries in non-graphical cachehistogram output.

This pull is mainly a line by line cherrypick revert of 15fa53d.

@@ -102,6 +105,17 @@ void SantaDecisionManager::ConnectClient(pid_t pid) {

client_pid_ = pid;

// Determine root fsid
vfs_context_t ctx = vfs_context_create(NULL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use nullptr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

/**
Clears the cache(s). If non_root_only is true, only the non-root cache
is cleared.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent -1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

@tburgin tburgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@@ -102,6 +105,17 @@ void SantaDecisionManager::ConnectClient(pid_t pid) {

client_pid_ = pid;

// Determine root fsid
vfs_context_t ctx = vfs_context_create(NULL);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

/**
Clears the cache(s). If non_root_only is true, only the non-root cache
is cleared.
*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tburgin tburgin merged commit 01df462 into google:master Sep 26, 2018
dskfh pushed a commit to dskfh/santa that referenced this pull request Jul 17, 2020
* santa-driver: add back the root and non-root caches

* cachehistogram: clarify buckets and entries

* review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants