Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Re-enable layering_checks #1350

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ load("//:helper.bzl", "run_command")

package(
default_visibility = ["//:santa_package_group"],
# NOTE: layering_check is disabled in all Santa BUILD files because the feature
# works inconsistently between versions of bazel in a way that causes problems
# when pulling the GitHub source into the internal source tree for building.
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 0 additions & 1 deletion Source/common/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 0 additions & 1 deletion Source/gui/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

exports_files([
Expand Down
1 change: 0 additions & 1 deletion Source/santabundleservice/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 0 additions & 1 deletion Source/santactl/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 0 additions & 1 deletion Source/santad/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

proto_library(
Expand Down
1 change: 0 additions & 1 deletion Source/santad/ProcessTree/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

cc_library(
Expand Down
1 change: 0 additions & 1 deletion Source/santad/ProcessTree/annotations/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

cc_library(
Expand Down
1 change: 0 additions & 1 deletion Source/santametricservice/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 0 additions & 1 deletion Source/santametricservice/Formats/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 0 additions & 1 deletion Source/santametricservice/Writers/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 0 additions & 1 deletion Source/santasyncservice/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 0 additions & 1 deletion Testing/integration/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ load("//:helper.bzl", "run_command", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 0 additions & 1 deletion Testing/integration/VM/Common/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package(
default_visibility = [
"//Testing/integration/VM:__subpackages__",
],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 0 additions & 1 deletion external_patches/OCMock/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)
1 change: 0 additions & 1 deletion external_patches/moroz/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)
1 change: 0 additions & 1 deletion profiles/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
Loading