Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overrides disabled when running tests unless explicitly enabled #1312

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Overrides disabled when running tests unless explicitly enabled #1312

merged 4 commits into from
Mar 22, 2024

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Mar 20, 2024 •
edited
Loading

This change disables applying the config overrides file when running tests by default. You can override this behavior by setting the environment variable ENABLE_CONFIG_OVERRIDES. E.g.:

bazel test --test_env=ENABLE_CONFIG_OVERRIDES=1 ...other test args...

@mlw mlw added the testing label Mar 20, 2024
@mlw mlw requested a review from a team as a code owner March 20, 2024 00:50
@mlw mlw changed the title Emit a log warning when overrides were applied Overrides disabled when running tests unless explicitly enabled Mar 20, 2024
@mlw mlw added this to the 2024.3 milestone Mar 20, 2024
pmarkowsky
pmarkowsky reviewed Mar 22, 2024
View reviewed changes
Source/common/SNTConfigurator.m Outdated Show resolved Hide resolved
Source/common/SNTConfigurator.m Outdated Show resolved Hide resolved
@mlw mlw force-pushed the warn-with-overrides branch from cadc9ff to 818db5d Compare March 22, 2024 17:20
pmarkowsky
pmarkowsky previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pmarkowsky pmarkowsky self-requested a review March 22, 2024 20:15
pmarkowsky
pmarkowsky approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlw mlw merged commit b379819 into google:main Mar 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mlw @pmarkowsky