Add support for CDHash rule types #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
added
docs
|
Work for #677 |
|
Fixes #677 |
russellhancox
previously approved these changes
Mar 5, 2024
russellhancox
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for CDHash rules. This rule is now the highest precedence rule that Santa supports. After this PR, the precedence chain is now
CDHash > Binary SHA-256 > Signing ID > Cert SHA-256 > Team ID > File Scopes.This PR also adds new sync server keys to match existing rule types (such as rule counts in
Preflight, uploading a binary's cdhash inEventUpload, and accepting CDHASH rule types.Some minor reworking of an old interfaces was done to further reduce the tedium of adding new rule types in the future (supplementing the work started in #1298.
Fixes #677