Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entitlements logging config options #1233

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Entitlements logging config options #1233

merged 5 commits into from
Nov 13, 2023

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Nov 10, 2023

Adds two configuration options supporting entitlement logging:

  • EntitlementsTeamIDFilter - Filter out entitlements from binaries from configured organizations
  • EntitlementsPrefixFilter - Filter out specific entitlement prefixes

@mlw mlw added logging santad Work related to the Santa Daemon configurator labels Nov 10, 2023
@mlw mlw added this to the 2023.10 Release milestone Nov 10, 2023
@mlw mlw requested a review from a team as a code owner November 10, 2023 19:17
kallsyms
kallsyms reviewed Nov 10, 2023
View reviewed changes
Source/common/SNTConfigurator.h Show resolved Hide resolved
Source/santad/Santad.mm Outdated Show resolved Hide resolved
pmarkowsky
pmarkowsky suggested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is renaming the mutex. Otherwise this seems fine.

Please treat the other suggestions as nits.

Source/santad/SNTExecutionController.mm Show resolved Hide resolved
Source/santad/SNTExecutionController.mm Outdated Show resolved Hide resolved
Source/santad/SNTPolicyProcessor.m Outdated Show resolved Hide resolved
pmarkowsky
pmarkowsky approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for making that change.

@mlw mlw merged commit a5e8d77 into google:main Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallsyms kallsyms kallsyms left review comments

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
configurator logging santad Work related to the Santa Daemon
Projects
None yet
Milestone
2023.10 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mlw @pmarkowsky @kallsyms