Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E testing for usb #1214

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Add E2E testing for usb #1214

merged 7 commits into from
Nov 1, 2023

Conversation

kallsyms
Copy link
Contributor

@kallsyms kallsyms commented Oct 30, 2023 •
edited
Loading

This adds infrastructure and basic tests around USB blocking. In short:

  • Add flags to VMGUI/VMCLI to connect a virtual USB drive backed by a dmg
  • Test that:
    • By default, volumes are R/W
    • With USB blocking and remount flags set to readonly,noexec:
      • Writeable mounts are correctly denied and remounted ro,noexec
      • Mounting explicitly with ro,noexec is permitted

Successful run: https://github.com/kallsyms/santa/actions/runs/6699996389/job/18205140600

pmarkowsky
pmarkowsky approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kallsyms kallsyms marked this pull request as ready for review November 1, 2023 15:38
@kallsyms kallsyms requested a review from a team as a code owner November 1, 2023 15:38
@kallsyms kallsyms merged commit 7530b8f into google:main Nov 1, 2023
1 check passed
@kallsyms kallsyms deleted the e2e-usb branch November 1, 2023 15:44
@pmarkowsky pmarkowsky added this to the 2023.9 Release milestone Nov 2, 2023
@kallsyms kallsyms mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

@mlw mlw mlw approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
2023.9 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@kallsyms @mlw @pmarkowsky