Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI For Blocked File Access #1174

Merged
merged 15 commits into from
Sep 13, 2023
Merged

UI For Blocked File Access #1174

merged 15 commits into from
Sep 13, 2023

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Sep 5, 2023 •
edited
Loading

This PR adds UI and TTY messaging when access to a resource is blocked via the File Access Authorization feature.

Screenshot 2023-09-06 at 2 35 25 PM

#1084

@mlw mlw added santad Work related to the Santa Daemon gui file access authorization labels Sep 5, 2023
@mlw mlw requested a review from a team as a code owner September 5, 2023 00:09
pmarkowsky
pmarkowsky reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. My only concern is the persist application in the dock when testing with this.

Screenshot 2023-09-05 at 16 33 07

Source/santad/TTYWriter.mm Show resolved Hide resolved
Source/common/CertificateHelpers.h Outdated Show resolved Hide resolved
russellhancox
russellhancox reviewed Sep 5, 2023
View reviewed changes
Source/common/CertificateHelpers.h Outdated Show resolved Hide resolved
Source/common/CertificateHelpers.h Outdated Show resolved Hide resolved
Source/common/CertificateHelpers.m Outdated Show resolved Hide resolved
Source/common/SNTFileAccessEvent.m Outdated Show resolved Hide resolved
Source/gui/SNTBinaryMessageWindowController.m Outdated Show resolved Hide resolved
Source/santad/SNTExecutionController.mm Outdated Show resolved Hide resolved
Source/santad/TTYWriter.h Show resolved Hide resolved
mlw and others added 15 commits September 12, 2023 13:43
@mlw
WIP: UI: open cert modal, hookup silence checkbox. Add cert helper fu…
307cab6 
…ncs.
@mlw
Popup dialog on file access violation. Support config-based and custo…
10e2cce 
…m messages.
@mlw
Send message to TTY on file access rule violation
922b271
@mlw
TTYWriter Write now takes an es_process_t. Fix async data lifespan is…
5f74191 
…sue.
@mlw
Dedupe TTY message printing per process per rule
f74362a
@mlw
Some minor swift beautification
9b1d684
@mlw
Remove main app from dock when showing file access dialog
ad7edad
@mlw
Update header docs
7022771
@mlw
Remove define guards for ObjC header file
d2408bf
@mlw @russellhancox
Update Source/common/CertificateHelpers.h
b07e399 
Co-authored-by: Russell Hancox <[email protected]>
@mlw @russellhancox
Fix comment typo
112017c 
Co-authored-by: Russell Hancox <[email protected]>
@mlw
Use #import for ObjC headers
0f98888
@mlw @russellhancox
Use #import for ObjC header
ae84272 
Co-authored-by: Russell Hancox <[email protected]>
@mlw
lint
dd55437
@mlw
Comment use of escape sequences
76a115a
@pmarkowsky pmarkowsky added this to the 2023.8 Release milestone Sep 12, 2023
@mlw mlw merged commit 3be45fd into google:main Sep 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky left review comments

@russellhancox russellhancox russellhancox left review comments

@kallsyms kallsyms kallsyms approved these changes

Assignees
No one assigned
Labels
file access authorization gui santad Work related to the Santa Daemon
Projects
None yet
Milestone
2023.8 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@mlw @russellhancox @pmarkowsky @kallsyms