Project: Disable layering_check in all BUILD files (#1344)

BUILD

@@ -1,7 +1,13 @@
 load("@build_bazel_rules_apple//apple:versioning.bzl", "apple_bundle_version")
 load("//:helper.bzl", "run_command")
 
-package(default_visibility = ["//:santa_package_group"])
+package(
+    default_visibility = ["//:santa_package_group"],
+    # NOTE: layering_check is disabled in all Santa BUILD files because the feature
+    # works inconsistently between versions of bazel in a way that causes problems
+    # when pulling the GitHub source into the internal source tree for building.
+    features = ["-layering_check"],
+)
 
 licenses(["notice"])
 

Source/common/BUILD

@@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 licenses(["notice"])

Source/gui/BUILD

@@ -6,6 +6,7 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 exports_files([

Source/santabundleservice/BUILD

@@ -4,6 +4,7 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 objc_library(

Source/santactl/BUILD

@@ -5,6 +5,7 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 objc_library(

Source/santad/BUILD

@@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 licenses(["notice"])

Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD

@@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 proto_library(

Source/santad/ProcessTree/BUILD

@@ -1,10 +1,14 @@
 load("@rules_cc//cc:defs.bzl", "cc_proto_library")
 load("//:helper.bzl", "santa_unit_test")
 
+package(
+    default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
+)
+
 cc_library(
     name = "process",
     hdrs = ["process.h"],
-    visibility = ["//:santa_package_group"],
     deps = [
         "//Source/santad/ProcessTree/annotations:annotator",
         "@com_google_absl//absl/container:flat_hash_map",
@@ -26,7 +30,6 @@ objc_library(
     sdk_dylibs = [
         "bsm",
     ],
-    visibility = ["//:santa_package_group"],
     deps = [
         ":process",
         "//Source/santad/ProcessTree:process_tree_cc_proto",
@@ -42,12 +45,10 @@ objc_library(
 proto_library(
     name = "process_tree_proto",
     srcs = ["process_tree.proto"],
-    visibility = ["//:santa_package_group"],
 )
 
 cc_proto_library(
     name = "process_tree_cc_proto",
-    visibility = ["//:santa_package_group"],
     deps = [":process_tree_proto"],
 )
 
@@ -58,7 +59,6 @@ objc_library(
     sdk_dylibs = [
         "bsm",
     ],
-    visibility = ["//:santa_package_group"],
     deps = [
         ":process_tree",
         "//Source/santad:EndpointSecurityAPI",
@@ -71,7 +71,6 @@ objc_library(
     name = "process_tree_test_helpers",
     srcs = ["process_tree_test_helpers.mm"],
     hdrs = ["process_tree_test_helpers.h"],
-    visibility = ["//Source/santad/ProcessTree:__subpackages__"],
     deps = [
         ":process",
         ":process_tree",

Source/santad/ProcessTree/annotations/BUILD

@@ -2,6 +2,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 cc_library(

Source/santametricservice/BUILD

@@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 licenses(["notice"])

Source/santametricservice/Formats/BUILD

@@ -2,6 +2,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 licenses(["notice"])

Source/santametricservice/Writers/BUILD

@@ -2,6 +2,7 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 licenses(["notice"])

Source/santasyncservice/BUILD

@@ -5,6 +5,7 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 objc_library(

Testing/integration/BUILD

@@ -1,6 +1,9 @@
 load("//:helper.bzl", "run_command", "santa_unit_test")
 
-package(default_visibility = ["//:santa_package_group"])
+package(
+    default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
+)
 
 licenses(["notice"])
 

Testing/integration/VM/Common/BUILD

@@ -2,6 +2,7 @@ package(
     default_visibility = [
         "//Testing/integration/VM:__subpackages__",
     ],
+    features = ["-layering_check"],
 )
 
 objc_library(

external_patches/OCMock/BUILD

@@ -2,4 +2,5 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )

external_patches/moroz/BUILD

@@ -2,4 +2,5 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )

profiles/BUILD

@@ -1,5 +1,6 @@
 package(
     default_visibility = ["//:santa_package_group"],
+    features = ["-layering_check"],
 )
 
 licenses(["notice"])